Skip to content

[NFC] Adjust return type of getTypeOfExpressionWithoutApplying #11048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 19, 2017

Conversation

CodaFi
Copy link
Contributor

@CodaFi CodaFi commented Jul 19, 2017

A companion to #11047

Makes the return type of getTypeOfExpressionWithoutApplying just Type instead of Optional<Type> to eliminate a potential tri-state.

@CodaFi CodaFi requested a review from xedin July 19, 2017 01:53
@CodaFi
Copy link
Contributor Author

CodaFi commented Jul 19, 2017

@swift-ci please smoke test

@CodaFi CodaFi changed the title Optional illusion [NFC] Adjust return type of getTypeOfExpressionWithoutApplying Jul 19, 2017
@slavapestov
Copy link
Contributor

I think @rudkx or @xedin should review this before you merge it. There might be a good reason it's an optional.

@CodaFi CodaFi force-pushed the optional-illusion branch from a7a0f07 to c42f4ea Compare July 19, 2017 02:35
@CodaFi
Copy link
Contributor Author

CodaFi commented Jul 19, 2017

@swift-ci please smoke test

@rudkx
Copy link
Contributor

rudkx commented Jul 19, 2017

I don't see any uses that require using an Optional for this.

@CodaFi
Copy link
Contributor Author

CodaFi commented Jul 19, 2017

⛵️

@CodaFi CodaFi merged commit 2968b03 into swiftlang:master Jul 19, 2017
@CodaFi CodaFi deleted the optional-illusion branch July 19, 2017 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants