[NFC] Merge ExprCleaner and ExprCleanser #11047
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The distinction was made between these two because of rdar://25341015, wherein we needed a diagnostic that could detect the shadowing of global functions by calls in protocols that don't match any of the protocol's members. This used to function by hoping that we had an argument tuple type lying around after type checking. The expr cleaner would re-write that type into the AST and we would look up based on it. Now that we write Type() into the AST on failure, we must instead type check the component parts of the argument themselves to form a tuple type to make the lookup.
|
@swift-ci please smoke test |
CodaFi
commented
Jul 19, 2017
| for (auto *el : argTuple->getElements()) { | ||
| ConcreteDeclRef ref = nullptr; | ||
| auto typeResult = | ||
| TC.getTypeOfExpressionWithoutApplying(el, CS.DC, ref); |
There was a problem hiding this comment.
This return type doesn't make any sense... I'm not sure why this returns Optional<Type> but I have a hunch it was just left over from when @rudkx was here last. I'm going to make this return Type() on failure and see what happens.
There was a problem hiding this comment.
getTypeOfExpressionWithoutApplying() has returned an Optional<Type> since it was introduced in 69fdca4.
|
LGTM |
|
⛵️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The distinction was made between these two because of rdar://25341015,
wherein we needed a diagnostic that could detect the shadowing of
global functions by calls in protocols that don't match any
of the protocol's members.
This used to function by hoping that we had an argument tuple type lying
around after type checking. The expr cleaner would re-write that
type into the AST and we would look up based on it. Now that we write
Type() into the AST on failure, we must instead type check the
component parts of the argument themselves to form a tuple
type to make the lookup.
At the end of the day, this is a dirty hack that will go away when we have the type map stuff. In the mean time it's probably good to address structural issues like this now.