Sema: DeclChecker::visitTypeAliasDecl() does everything in the 'first pass'

Author: slavapestov

lib/Sema/TypeCheckDecl.cpp

@@ -4277,16 +4277,16 @@ class DeclChecker : public DeclVisitor<DeclChecker> {
   }
 
   void visitTypeAliasDecl(TypeAliasDecl *TAD) {
+    if (!IsFirstPass) {
+      return;
+    }
+
     TC.checkDeclAttributesEarly(TAD);
     TC.computeAccessLevel(TAD);
 
-    if (IsFirstPass)
-      TC.validateDecl(TAD);
-
-    if (!IsFirstPass)
-      checkAccessControl(TC, TAD);
-
+    TC.validateDecl(TAD);
     TC.checkDeclAttributes(TAD);
+    checkAccessControl(TC, TAD);
   }
 
   void visitAssociatedTypeDecl(AssociatedTypeDecl *assocType) {