Skip to content

Commit 3531852

Browse files
authored
Merge pull request #32250 from gottesmm/pr-962a7fcfad9a0049512c51e6da2e032c8a4a65e0
[build-script-impl] Require --install-llvm to be passed in to install llvm.
2 parents 28f60a0 + 452b6dd commit 3531852

File tree

2 files changed

+20
-3
lines changed

2 files changed

+20
-3
lines changed

utils/build-presets.ini

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@ build-ninja
3939

4040
build-swift-stdlib-unittest-extra
4141

42+
install-llvm
4243
install-swift
4344

4445
# Path to the root of the installation filesystem.
@@ -391,6 +392,7 @@ skip-test-ios
391392
skip-test-tvos
392393
skip-test-watchos
393394

395+
install-llvm
394396
install-swift
395397
install-llbuild
396398
install-swiftpm
@@ -602,6 +604,7 @@ llbuild
602604
swiftpm
603605
indexstore-db
604606
sourcekit-lsp
607+
install-llvm
605608
install-swift
606609
install-llbuild
607610
install-swiftpm
@@ -790,6 +793,7 @@ libcxx
790793
dash-dash
791794

792795
build-ninja
796+
install-llvm
793797
install-swift
794798
install-lldb
795799
install-llbuild
@@ -908,6 +912,7 @@ host-test
908912
extra-cmake-options=-DSWIFT_ENABLE_LLD_LINKER:BOOL=OFF
909913

910914
install-prefix=/usr
915+
install-llvm
911916
install-swift
912917
install-libicu
913918
install-libcxx
@@ -1016,6 +1021,7 @@ build-subdir=buildbot_linux
10161021

10171022
dash-dash
10181023

1024+
install-llvm
10191025
install-swift
10201026
install-lldb
10211027
install-llbuild
@@ -1076,6 +1082,7 @@ indexstore-db
10761082
sourcekit-lsp
10771083
dash-dash
10781084

1085+
install-llvm
10791086
install-swift
10801087
install-llbuild
10811088
install-libicu
@@ -1117,6 +1124,7 @@ build-subdir=buildbot_incremental_tsan_libdispatch_test
11171124

11181125
llvm-cmake-options=-DLLVM_INSTALL_UTILS=ON
11191126
llvm-install-components=all
1127+
install-llvm
11201128

11211129
libdispatch-cmake-options=-DENABLE_SWIFT=OFF
11221130
libdispatch
@@ -1208,6 +1216,7 @@ verbose-build
12081216
build-ninja
12091217
build-swift-stdlib-unittest-extra
12101218

1219+
install-llvm
12111220
install-swift
12121221
install-lldb
12131222
install-llbuild
@@ -1433,6 +1442,7 @@ build-swift-stdlib-unittest-extra
14331442
libcxx
14341443

14351444
# Install swift and libcxx
1445+
install-llvm
14361446
install-swift
14371447
install-libcxx
14381448

@@ -1481,6 +1491,7 @@ swiftsyntax-verify-generated-files
14811491
# Build sourcekit-lsp & indexstore-db
14821492
indexstore-db
14831493
sourcekit-lsp
1494+
install-llvm
14841495
install-swift
14851496
install-llbuild
14861497
install-swiftpm
@@ -1547,6 +1558,7 @@ libcxx
15471558
llbuild
15481559
swiftpm
15491560

1561+
install-llvm
15501562
install-swift
15511563
install-llbuild
15521564
install-swiftpm
@@ -1793,6 +1805,7 @@ install-foundation
17931805
install-libdispatch
17941806
install-libicu
17951807
install-libcxx
1808+
install-llvm
17961809
install-swift
17971810
install-llbuild
17981811
install-swiftpm
@@ -1828,6 +1841,7 @@ skip-build-cmark
18281841
skip-build-llvm
18291842
skip-build-llbuild
18301843
skip-build-benchmarks
1844+
install-llvm
18311845
install-swift
18321846
install-prefix=%(install_toolchain_dir)s/usr
18331847
build-swift-examples=0
@@ -2245,6 +2259,7 @@ no-assertions
22452259
build-libparser-only
22462260
verbose-build
22472261
darwin-install-extract-symbols
2262+
install-llvm
22482263
install-swift
22492264

22502265

@@ -2338,6 +2353,7 @@ build-ninja
23382353
llbuild
23392354
swiftpm
23402355
install-llbuild
2356+
install-llvm
23412357
install-swift
23422358
install-swiftpm
23432359
reconfigure

utils/build-script-impl

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2656,12 +2656,13 @@ for host in "${ALL_HOSTS[@]}"; do
26562656
fi
26572657
;;
26582658
llvm)
2659-
if [[ -z "${LLVM_INSTALL_COMPONENTS}" ]] ; then
2659+
if [[ -z "${INSTALL_LLVM}" ]] ; then
26602660
continue
26612661
fi
2662-
if [[ "${LLVM_INSTALL_COMPONENTS}" == "all" ]]; then
2662+
2663+
if [[ "${LLVM_INSTALL_COMPONENTS}" == "all" ]] ; then
26632664
INSTALL_TARGETS=install
2664-
else
2665+
elif [[ -n "${LLVM_INSTALL_COMPONENTS}" ]] ; then
26652666
INSTALL_TARGETS=install-$(echo ${LLVM_INSTALL_COMPONENTS} | sed -E 's/;/ install-/g')
26662667
fi
26672668
;;

0 commit comments

Comments
 (0)