[build-script-impl] Require --install-llvm to be passed in to install llvm. #32250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… llvm. Before this patch, we assumed that if LLVM_INSTALL_COMPONENTS was non-empty that we wanted to install llvm. This is different than /every other/ product in build-script-impl where INSTALL_$PRODUCT controls if an install is attempted. If a components sort of thing is required, we force it to only be a configuration of an option that is a no-op if INSTALL_$PRODUCT is set to true. I went through build-presets and looked at every place we had an install statement and added install-llvm when appropriate. This was generally when we did an install-swift. The one special case is with the tsan_libdsipatch test. That being said, if I was too aggressive with where I put these install-llvm, no harm will result since in those cases LLVM_INSTALL_COMPONENTS had to be empty previously anyways (since otherwise we would have attempted an install).
|
@swift-ci test |
benlangmuir
approved these changes
Jun 8, 2020
|
Build failed |
|
@swift-ci smoke test linux platform |
|
@swift-ci test linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this patch, we assumed that if LLVM_INSTALL_COMPONENTS was non-empty that
we wanted to install llvm. This is different than /every other/ product in
build-script-impl where INSTALL_$PRODUCT controls if an install is attempted. If
a components sort of thing is required, we force it to only be a configuration
of an option that is a no-op if INSTALL_$PRODUCT is set to true.
I went through build-presets and looked at every place we had an install
statement and added install-llvm when appropriate. This was generally when we
did an install-swift. The one special case is with the tsan_libdsipatch
test. That being said, if I was too aggressive with where I put these
install-llvm, no harm will result since in those cases LLVM_INSTALL_COMPONENTS
had to be empty previously anyways (since otherwise we would have attempted an
install).