Merge pull request #18786 from rintaro/parse-istypecontext

[Parse] Don't use getAsNominalTypeOrNominalTypeExtensionContext in Parse

Author: rintaro

lib/IDE/CodeCompletion.cpp

@@ -4311,7 +4311,7 @@ class CompletionOverrideLookup : public swift::VisibleDeclConsumer {
   }
 
   void getOverrideCompletions(SourceLoc Loc) {
-    if (!CurrDeclContext->getSelfNominalTypeDecl())
+    if (!CurrDeclContext->isTypeContext())
       return;
     if (isa<ProtocolDecl>(CurrDeclContext))
       return;

lib/Parse/ParsePattern.cpp

@@ -921,7 +921,7 @@ ParserResult<Pattern> Parser::parsePattern() {
   }
 
   case tok::code_complete:
-    if (!CurDeclContext->getSelfNominalTypeDecl()) {
+    if (!CurDeclContext->isTypeContext()) {
       // This cannot be an overridden property, so just eat the token. We cannot
       // code complete anything here -- we expect an identifier.
       consumeToken(tok::code_complete);

validation-test/IDE/crashers_2_fixed/sr8554.swift

@@ -0,0 +1,5 @@
+// RUN: %target-swift-ide-test -code-completion -code-completion-token=COMPLETE -source-filename=%s
+
+extension UnknownTy {
+  var #^COMPLETE^#
+}