[Parse] Don't use getAsNominalTypeOrNominalTypeExtensionContext in Parse #18786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
rintaro
commented
Aug 17, 2018
lib/IDE/CodeCompletion.cpp
Outdated
| @@ -4314,7 +4314,7 @@ class CompletionOverrideLookup : public swift::VisibleDeclConsumer { | |||
| } | |||
|
|
|||
| void getOverrideCompletions(SourceLoc Loc) { | |||
| if (!CurrDeclContext->getAsNominalTypeOrNominalTypeExtensionContext()) | |||
| if (!CurrDeclContext->isTypeContext()) | |||
There was a problem hiding this comment.
This is not necessary, but it's low cost.
|
Thank you! |
|
(Sorry for breaking your merge with #18798.) |
`getAsNominalTypeOrNominalTypeExtensionContext()` requires fully parsed AST. Use `isTypeContext()` instead. https://bugs.swift.org/browse/SR-8554 rdar://problem/43394866
rintaro
force-pushed
the
parse-istypecontext
branch
from
262134b to
682fc12
Compare
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DeclContext::getAsNominalTypeOrNominalTypeExtensionContext()getSelfNominalTypeDecl()requires fully parsed AST. UseisTypeContext()instead.https://bugs.swift.org/browse/SR-8554
rdar://problem/43394866