Merge pull request #30542 from marcrasi/fix-autocomplete-crash-callasfunction

Author: swift-ci

lib/IDE/CodeCompletion.cpp

@@ -3153,7 +3153,7 @@ class CompletionLookup final : public swift::VisibleDeclConsumer {
 
         // SE-0253: Callable values of user-defined nominal types.
         if (FD->isCallAsFunctionMethod() && !HaveDot &&
-            !ExprType->is<AnyMetatypeType>()) {
+            (!ExprType || !ExprType->is<AnyMetatypeType>())) {
           Type funcType = getTypeOfMember(FD, dynamicLookupInfo)
                               ->castTo<AnyFunctionType>()
                               ->getResult();

test/IDE/complete_crashes.swift

@@ -378,3 +378,14 @@ struct test_54215016 {
 // RDAR_54215016: Begin completions
   }
 }
+
+// RUN: %target-swift-ide-test -code-completion -code-completion-token=CRASH_CALL_AS_FUNCTION -source-filename=%s | %FileCheck %s -check-prefix=CRASH_CALL_AS_FUNCTION
+protocol HasCallAsFunctionRequirement {
+  func callAsFunction()
+}
+struct StructWithCallAsFunction: HasCallAsFunctionRequirement {
+  let f = #^CRASH_CALL_AS_FUNCTION^#
+  func callAsFunction() {}
+}
+// CRASH_CALL_AS_FUNCTION: Begin completion
+// CRASH_CALL_AS_FUNCTION: End completions