Skip to content

Commit 47aa977

Browse files
pi1024eCodaFi
authored andcommitted
Simplifying the flow (#28010)
* Simplified flow of Platform.cpp to reduce number of branches * Update Platform.cpp * Update Platform.cpp
1 parent 4bf9025 commit 47aa977

File tree

1 file changed

+12
-23
lines changed

1 file changed

+12
-23
lines changed

lib/Basic/Platform.cpp

Lines changed: 12 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -54,17 +54,18 @@ bool swift::tripleIsAnySimulator(const llvm::Triple &triple) {
5454
tripleIsAppleTVSimulator(triple);
5555
}
5656

57-
5857
bool swift::tripleRequiresRPathForSwiftInOS(const llvm::Triple &triple) {
5958
if (triple.isMacOSX()) {
6059
// macOS 10.14.4 contains a copy of Swift, but the linker will still use an
6160
// rpath-based install name until 10.15.
6261
return triple.isMacOSXVersionLT(10, 15);
62+
}
6363

64-
} else if (triple.isiOS()) {
64+
if (triple.isiOS()) {
6565
return triple.isOSVersionLT(12, 2);
66+
}
6667

67-
} else if (triple.isWatchOS()) {
68+
if (triple.isWatchOS()) {
6869
return triple.isOSVersionLT(5, 2);
6970
}
7071

@@ -196,20 +197,16 @@ StringRef swift::getPlatformNameForTriple(const llvm::Triple &triple) {
196197

197198
StringRef swift::getMajorArchitectureName(const llvm::Triple &Triple) {
198199
if (Triple.isOSLinux()) {
199-
switch(Triple.getSubArch()) {
200-
default:
201-
return Triple.getArchName();
202-
break;
200+
switch (Triple.getSubArch()) {
203201
case llvm::Triple::SubArchType::ARMSubArch_v7:
204202
return "armv7";
205-
break;
206203
case llvm::Triple::SubArchType::ARMSubArch_v6:
207204
return "armv6";
205+
default:
208206
break;
209207
}
210-
} else {
211-
return Triple.getArchName();
212208
}
209+
return Triple.getArchName();
213210
}
214211

215212
// The code below is responsible for normalizing target triples into the form
@@ -345,42 +342,34 @@ llvm::Triple swift::getTargetSpecificModuleTriple(const llvm::Triple &triple) {
345342
}
346343

347344
Optional<llvm::VersionTuple>
348-
swift::getSwiftRuntimeCompatibilityVersionForTarget(const llvm::Triple &Triple){
345+
swift::getSwiftRuntimeCompatibilityVersionForTarget(
346+
const llvm::Triple &Triple) {
349347
unsigned Major, Minor, Micro;
350-
348+
351349
if (Triple.isMacOSX()) {
352350
Triple.getMacOSXVersion(Major, Minor, Micro);
353351
if (Major == 10) {
354352
if (Minor <= 14) {
355353
return llvm::VersionTuple(5, 0);
356354
} else if (Minor <= 15) {
357355
return llvm::VersionTuple(5, 1);
358-
} else {
359-
return None;
360356
}
361-
} else {
362-
return None;
363357
}
364358
} else if (Triple.isiOS()) { // includes tvOS
365359
Triple.getiOSVersion(Major, Minor, Micro);
366360
if (Major <= 12) {
367361
return llvm::VersionTuple(5, 0);
368362
} else if (Major <= 13) {
369363
return llvm::VersionTuple(5, 1);
370-
} else {
371-
return None;
372364
}
373365
} else if (Triple.isWatchOS()) {
374366
Triple.getWatchOSVersion(Major, Minor, Micro);
375367
if (Major <= 5) {
376368
return llvm::VersionTuple(5, 0);
377369
} else if (Major <= 6) {
378370
return llvm::VersionTuple(5, 1);
379-
} else {
380-
return None;
381371
}
382-
} else {
383-
return None;
384372
}
385-
}
386373

374+
return None;
375+
}

0 commit comments

Comments
 (0)