Simplifying the flow #28010
Merged
Simplifying the flow #28010
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good! Could you run clang-format really quickly to patch up the switch statement? |
|
Did but clang format causes some other changes as well for some reason. |
|
I recommend using the |
|
Done. thank you |
CodaFi
requested changes
Nov 2, 2019
|
Addressed |
xwu
reviewed
Nov 3, 2019
|
I managed to fix everything |
ghost
requested review from
xwu
reviewed
Nov 6, 2019
|
Fixed and rebased! |
xwu
reviewed
Nov 7, 2019
|
Done |
|
That looks better @swift-ci please smoke test |
CodaFi
approved these changes
Nov 8, 2019
|
No probs! |
thejohnlima
approved these changes
Nov 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To the average programmer, looking at the original code shows plenty of branches that result in returning None. Because there are all contained in else statements, they can be somewhat hard to follow. For this reason, I put the bottom else statement out of the clause, and have it so that after each brach, if nothing returns, it would go to one return None statement.
Resolves SR-NNNN.