Skip to content

Commit 48c1931

Browse files
authored
Unbreak delta reporting in benchmarks (#61236)
The logic here was apparently intended to omit literal zeros from deltas to save a few bytes, but it instead drops all zeros from all columns. Remove the condition that drops zeros in order to avoid confusing the many scripts that consume this data. Alternatives Considered I'm probably going to entirely drop the delta form in an upcoming PR, so I didn't think it was worthwhile to do something more complex, such as: * Fixing this logic to only omit zeros from actual delta columns * Rewriting all the client scripts to treat any empty column as zero
1 parent ccb2e04 commit 48c1931

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

benchmark/utils/DriverUtils.swift

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -665,8 +665,7 @@ final class TestRunner {
665665
(c.logMemory ? [r.meta?.maxRSS].compactMap { $0 } : []) +
666666
(c.logMeta ? r.meta.map {
667667
[$0.pages, $0.ics, $0.yields] } ?? [] : [])
668-
return values.map {
669-
(c.delta && $0 == 0) ? "" : String($0) } // drop 0s in deltas
668+
return values.map { String($0) }
670669
}
671670
let benchmarkStats = (
672671
[index, t.name] + (results.map(values) ?? ["Unsupported"])

0 commit comments

Comments
 (0)