Unbreak delta reporting in benchmarks #61236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The logic here was apparently intended to omit literal zeros from deltas to save a few bytes, but it instead drops all zeros from all columns. Remove the condition that drops zeros in order to avoid confusing the many scripts that consume this data. Alternatives Considered I'm probably going to entirely drop the delta form in an upcoming PR, so I didn't think it was worthwhile to do something more complex, such as: * Fixing this logic to only omit zeros from actual delta columns * Rewriting all the client scripts to treat any empty column as zero
|
@swift-ci Please test |
|
@swift-ci Please benchmark |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build-script -Bhas been broken for me for a while. I finally tracked it down to this bit of code.The logic here was apparently intended to omit literal zeros from deltas to save a few bytes, but it instead drops all zeros from all columns. Remove the condition that drops zeros in order to avoid confusing the many scripts that consume this data.
Alternatives Considered
I'm probably going to entirely drop the delta form in an upcoming PR, so I didn't think it was worthwhile to do something more complex, such as:
Fixing this logic to only omit zeros from actual delta columns
Rewriting all the client scripts to treat any empty column as zero