Merge pull request #29866 from xedin/rdar-57356196

[CSApply] Always use `String` type for ObjC interop key path

Author: xedin

lib/Sema/CSApply.cpp

@@ -4312,7 +4312,7 @@ namespace {
                                  StringRef(stringCopy, compatStringBuf.size()),
                                  SourceRange(),
                                  /*implicit*/ true);
-          cs.setType(stringExpr, cs.getType(E));
+          cs.setType(stringExpr, TypeChecker::getStringType(cs.getASTContext()));
           E->setObjCStringLiteralExpr(stringExpr);
         }
       }

validation-test/compiler_crashers_2_fixed/0210-rdar57356196.swift

@@ -0,0 +1,21 @@
+// RUN: %target-swift-frontend(mock-sdk: %clang-importer-sdk) %s -typecheck -verify
+// REQUIRES: objc_interop
+
+import Foundation
+
+@objc class A : NSObject {
+  @objc var x: Int = 42
+}
+
+@propertyWrapper
+struct Attr<V> {
+  var wrappedValue: V {
+    get { fatalError() }
+  }
+
+  init(wrappedValue: V, key: KeyPath<A, V>) {}
+}
+
+class B {
+  @Attr(key: \.x) var y: Int = 0 // Ok
+}