[CSApply] Always use `String` type for ObjC interop key path #29866

xedin · 2020-02-15T08:08:48Z

If it's possible to build an Objective-C key path for key path
expression make sure that its implicitly generated string literal
expression has a String type.

Resolves: rdar://problem/57356196

If it's possible to build an Objective-C key path for key path expression make sure that its implicitly generated string literal expression has a `String` type. Resolves: rdar://problem/57356196

xedin · 2020-02-15T08:09:16Z

@swift-ci please smoke test

xedin · 2020-02-15T08:10:50Z

@swift-ci please test source compatibility

xedin · 2020-02-15T17:33:25Z

SwiftNIO failures are unrelated:

/Users/buildnode/jenkins/workspace/swift-PR-source-compat-suite/swift-source-compat-suite/project_cache/swift-nio-extras/.build/checkouts/swift-nio/Sources/NIOHTTP1/HTTPResponseCompressor.swift:41:18: error: 'init(_:)' is only available in macOS 9999 or newer
    let qValue = Float(headerParts[1].split(separator: "=", maxSplits: 1, omittingEmptySubsequences: false)[1]) ?? 0
                 ^
/Users/buildnode/jenkins/workspace/swift-PR-source-compat-suite/swift-source-compat-suite/project_cache/swift-nio-extras/.build/checkouts/swift-nio/Sources/NIOHTTP1/HTTPResponseCompressor.swift:41:18: note: add 'if #available' version check
    let qValue = Float(headerParts[1].split(separator: "=", maxSplits: 1, omittingEmptySubsequences: false)[1]) ?? 0
                 ^
/Users/buildnode/jenkins/workspace/swift-PR-source-compat-suite/swift-source-compat-suite/project_cache/swift-nio-extras/.build/checkouts/swift-nio/Sources/NIOHTTP1/HTTPResponseCompressor.swift:34:14: note: add @available attribute to enclosing global function
private func qValueFromHeader(_ text: String) -> Float {
             ^

xedin · 2020-02-15T17:34:09Z

@swift-ci please test

swift-ci · 2020-02-15T19:04:55Z

Build failed
Swift Test Linux Platform
Git Sha - ae79b0d

xedin · 2020-02-15T19:44:08Z