SIL: Remove FormalLinkage::HiddenNonUnique

Author: slavapestov

include/swift/SIL/FormalLinkage.h

@@ -37,10 +37,6 @@ enum class FormalLinkage {
   /// unique file that is known to define it.
   HiddenUnique,
 
-  /// This entity is visible in only a single Swift module but does not
-  /// have a unique file that is known to define it.
-  HiddenNonUnique,
-
   /// This entity is visible in only a single Swift file. These are by
   /// definition unique.
   Private,

lib/IRGen/GenDecl.cpp

@@ -94,7 +94,6 @@ bool IRGenerator::tryEnableLazyTypeMetadata(NominalTypeDecl *Nominal) {
       // We can't remove metadata for externally visible types.
       return false;
     case FormalLinkage::HiddenUnique:
-    case FormalLinkage::HiddenNonUnique:
       // In non-whole-module mode, also internal types are visible externally.
       if (!SIL.isWholeModule())
         return false;
@@ -1418,7 +1417,6 @@ static SILLinkage getNonUniqueSILLinkage(FormalLinkage linkage,
     return (forDefinition ? SILLinkage::Shared : SILLinkage::PublicExternal);
 
   case FormalLinkage::HiddenUnique:
-  case FormalLinkage::HiddenNonUnique:
     return (forDefinition ? SILLinkage::Shared : SILLinkage::HiddenExternal);
 
   case FormalLinkage::Private:
@@ -1541,7 +1539,6 @@ SILLinkage LinkEntity::getLinkage(ForDefinition_t forDefinition) const {
     // Resilient classes don't expose field offset symbols.
     if (cast<ClassDecl>(varDecl->getDeclContext())->isResilient()) {
       assert(linkage != FormalLinkage::PublicNonUnique &&
-             linkage != FormalLinkage::HiddenNonUnique &&
             "Cannot have a resilient class with non-unique linkage");
 
       if (linkage == FormalLinkage::PublicUnique)

lib/IRGen/MetadataRequest.cpp

@@ -635,7 +635,6 @@ MetadataAccessStrategy irgen::getTypeMetadataAccessStrategy(CanType type) {
       return MetadataAccessStrategy::PrivateAccessor;
 
     case FormalLinkage::PublicNonUnique:
-    case FormalLinkage::HiddenNonUnique:
       return MetadataAccessStrategy::NonUniqueAccessor;
     }
     llvm_unreachable("bad formal linkage");

lib/SIL/SIL.cpp

@@ -77,9 +77,6 @@ SILLinkage swift::getSILLinkage(FormalLinkage linkage,
   case FormalLinkage::HiddenUnique:
     return (forDefinition ? SILLinkage::Hidden : SILLinkage::HiddenExternal);
 
-  case FormalLinkage::HiddenNonUnique:
-    return (forDefinition ? SILLinkage::Shared : SILLinkage::HiddenExternal);
-
   case FormalLinkage::Private:
     return SILLinkage::Private;
   }

lib/SIL/SILProfiler.cpp

@@ -886,7 +886,6 @@ getEquivalentPGOLinkage(FormalLinkage Linkage) {
     return llvm::GlobalValue::ExternalLinkage;
 
   case FormalLinkage::HiddenUnique:
-  case FormalLinkage::HiddenNonUnique:
   case FormalLinkage::Private:
     return llvm::GlobalValue::PrivateLinkage;
   }