Merge pull request #33964 from dan-zheng/tensorflow-autodiff-fixes

[AutoDiff] Fix PullbackCloner tangent value category mismatch issues.

Author: dan-zheng

lib/SIL/IR/SILFunctionType.cpp

@@ -537,6 +537,8 @@ static CanSILFunctionType getAutoDiffPullbackType(
         TC.getTypeLowering(pattern, tanType, TypeExpansionContext::minimal());
     ParameterConvention conv;
     switch (origResConv) {
+    case ResultConvention::Unowned:
+    case ResultConvention::UnownedInnerPointer:
     case ResultConvention::Owned:
     case ResultConvention::Autoreleased:
       if (tl.isAddressOnly()) {
@@ -546,10 +548,6 @@ static CanSILFunctionType getAutoDiffPullbackType(
                               : ParameterConvention::Direct_Guaranteed;
       }
       break;
-    case ResultConvention::Unowned:
-    case ResultConvention::UnownedInnerPointer:
-      conv = ParameterConvention::Direct_Unowned;
-      break;
     case ResultConvention::Indirect:
       conv = ParameterConvention::Indirect_In_Guaranteed;
       break;

lib/SILOptimizer/Analysis/DifferentiableActivityAnalysis.cpp

@@ -557,6 +557,8 @@ void DifferentiableActivityInfo::dump(SILAutoDiffIndices indices,
     for (auto &inst : bb)
       for (auto res : inst.getResults())
         dump(res, indices, s);
-    s << '\n';
+    if (std::next(bb.getIterator()) != fn.end())
+      s << '\n';
   }
+  s << "End activity info for " << fn.getName() << " at " << indices << "\n\n";
 }