[AutoDiff] Fix PullbackCloner tangent value category mismatch issues. #33964
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test tensorflow |
End markers are useful for FileCheck.
Fix SIL pullback function type calculation: remap original `unowned` results to the correct pullback parameter convention depending on the `TangentVector` type lowering. Make `PullbackCloner` visitors for the following instructions check and handle tangent value categories: `struct`, `struct_extract`, `tuple`, `destructure_tuple`. Add differentiation tests for `Optional` struct and class stored properties, exercising the instruction visitors above. Resolves SR-13430.
efremale
approved these changes
Sep 16, 2020
Fixes a use-after-free crash.
dan-zheng
force-pushed
the
tensorflow-autodiff-fixes
branch
from
b1fb088 to
2ee26da
Compare
|
@swift-ci Please test tensorflow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #33611 to
tensorflowbranch.Fix SIL pullback function type calculation: remap original
unownedresults tothe correct pullback parameter convention depending on the
TangentVectortypelowering.
Make
PullbackClonervisitors for the following instructions check and handletangent value categories:
struct,struct_extract,tuple,destructure_tuple.Add differentiation tests for
Optionalstruct and class stored properties,exercising the instruction visitors above.
Resolves SR-13430.