Merge pull request #35919 from apple/QuietMisdreavus/invalid-range-raw-comment

don't load raw comments for invalid serialized ranges

Author: QuietMisdreavus

lib/AST/RawComment.cpp

@@ -154,7 +154,14 @@ RawComment Decl::getRawComment(bool SerializedOK) const {
         if (!CachedLocs->DocRanges.empty()) {
           SmallVector<SingleRawComment, 4> SRCs;
           for (const auto &Range : CachedLocs->DocRanges) {
-            SRCs.push_back({ Range, Context.SourceMgr });
+            if (Range.isValid()) {
+              SRCs.push_back({ Range, Context.SourceMgr });
+            } else {
+              // if we've run into an invalid range, don't bother trying to load any of
+              // the other comments
+              SRCs.clear();
+              break;
+            }
           }
           auto RC = RawComment(Context.AllocateCopy(llvm::makeArrayRef(SRCs)));
 

test/SymbolGraph/Module/NoSourceInfo.swift

@@ -0,0 +1,33 @@
+// RUN: %empty-directory(%t)
+// RUN: %empty-directory(%t/Source)
+// RUN: %empty-directory(%t/NoSourceInfo.framework/Modules/NoSourceInfo.swiftmodule)
+// RUN: %empty-directory(%t/NoSourceInfo.framework/Modules/NoSourceInfo.swiftmodule/Project)
+
+// RUN: cp %s %t/Source/Input.swift
+
+// RUN: %target-swift-frontend -module-name NoSourceInfo -emit-module -emit-module-path %t/NoSourceInfo.framework/Modules/NoSourceInfo.swiftmodule/%target-swiftmodule-name -emit-module-doc-path %t/NoSourceInfo.framework/Modules/NoSourceInfo.swiftmodule/%target-swiftdoc-name -emit-module-interface-path %t/NoSourceInfo.framework/Modules/NoSourceInfo.swiftmodule/%target-swiftinterface-name -emit-module-source-info-path %t/NoSourceInfo.framework/Modules/NoSourceInfo.swiftmodule/Project/%target-swiftsourceinfo-name %t/Source/Input.swift
+
+// RUN: mv %t/Source %t/MovedSource
+
+// RUN: %target-swift-symbolgraph-extract -module-name NoSourceInfo -F %t -pretty-print -output-dir %t
+// RUN: %FileCheck %s --input-file %t/NoSourceInfo.symbols.json
+
+// CHECK: s:12NoSourceInfo1SV
+// CHECK: docComment
+// CHECK: This is a test
+
+/// This is a test
+public struct S {
+    /// This is also a test
+    public var x: Int
+}
+
+/// writing some docs here
+open class C<Data> {
+    /// writing more docs over there
+    public init() {}
+}
+
+open class CO: C<String> {
+    override public init() { super.init() }
+}