Skip to content

Commit 5816991

Browse files
authored
Merge pull request #23258 from drodriguez/dont-remove-partial-results
2 parents e9208f4 + 29ec87e commit 5816991

File tree

1 file changed

+8
-5
lines changed

1 file changed

+8
-5
lines changed

utils/build-script-impl

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2613,7 +2613,8 @@ for host in "${ALL_HOSTS[@]}"; do
26132613
;;
26142614
*)
26152615
# FIXME: Always re-build XCTest on non-darwin platforms.
2616-
# Remove this when products build in the CMake system.
2616+
# The Swift project might have been changed, but CMake might
2617+
# not be aware and will not rebuild.
26172618
echo "Cleaning the XCTest build directory"
26182619
call rm -rf "${XCTEST_BUILD_DIR}"
26192620

@@ -2687,8 +2688,9 @@ for host in "${ALL_HOSTS[@]}"; do
26872688
LIBDISPATCH_BUILD_ARGS=( -DFOUNDATION_ENABLE_LIBDISPATCH=NO )
26882689
fi
26892690

2690-
# FIXME: Always re-build foundation on non-darwin platforms.
2691-
# Remove this when products build in the CMake system.
2691+
# FIXME: Always re-build XCTest on non-darwin platforms.
2692+
# The Swift project might have been changed, but CMake might
2693+
# not be aware and will not rebuild.
26922694
echo "Cleaning the Foundation build directory"
26932695
call rm -rf "${build_dir}"
26942696

@@ -2763,8 +2765,9 @@ for host in "${ALL_HOSTS[@]}"; do
27632765
continue
27642766
;;
27652767
*)
2766-
# FIXME: Always re-build libdispatch on non-darwin platforms.
2767-
# Remove this when products build in the CMake system.
2768+
# FIXME: Always re-build XCTest on non-darwin platforms.
2769+
# The Swift project might have been changed, but CMake might
2770+
# not be aware and will not rebuild.
27682771
echo "Cleaning the libdispatch build directory"
27692772
call rm -rf "${LIBDISPATCH_BUILD_DIR}"
27702773

0 commit comments

Comments
 (0)