[build-script-impl] Remove three FIXME which removed build products. #23258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
IIRC, the problem here was that it wouldn't rebuild on swiftCore changes without a clean build. @gottesmm might remember better than I do. |
|
@compnerd +1 |
|
That makes sense. I will modify the comment to be more clear. Thanks! |
Dispatch, Foundation and XCTest build using CMake since a couple of months ago, so there's no need to remove the partial results before building anymore. This should make rebuilding a little bit faster.
drodriguez
force-pushed
the
dont-remove-partial-results
branch
from
2c68fcd to
29ec87e
Compare
compnerd
approved these changes
Mar 13, 2019
|
@swift-ci please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dispatch, Foundation and XCTest build using CMake since a couple of
months ago, so there's no need to remove the partial results before
building anymore. This should make rebuilding a little bit faster.
/cc @compnerd