Skip to content

[build-script-impl] Remove three FIXME which removed build products. #23258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2019
Merged

[build-script-impl] Remove three FIXME which removed build products. #23258

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions utils/build-script-impl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2613,7 +2613,8 @@ for host in "${ALL_HOSTS[@]}"; do
;;
*)
# FIXME: Always re-build XCTest on non-darwin platforms.
# Remove this when products build in the CMake system.
# The Swift project might have been changed, but CMake might
# not be aware and will not rebuild.
echo "Cleaning the XCTest build directory"
call rm -rf "${XCTEST_BUILD_DIR}"

Expand Down Expand Up @@ -2687,8 +2688,9 @@ for host in "${ALL_HOSTS[@]}"; do
LIBDISPATCH_BUILD_ARGS=( -DFOUNDATION_ENABLE_LIBDISPATCH=NO )
fi

# FIXME: Always re-build foundation on non-darwin platforms.
# Remove this when products build in the CMake system.
# FIXME: Always re-build XCTest on non-darwin platforms.
# The Swift project might have been changed, but CMake might
# not be aware and will not rebuild.
echo "Cleaning the Foundation build directory"
call rm -rf "${build_dir}"

Expand Down Expand Up @@ -2763,8 +2765,9 @@ for host in "${ALL_HOSTS[@]}"; do
continue
;;
*)
# FIXME: Always re-build libdispatch on non-darwin platforms.
# Remove this when products build in the CMake system.
# FIXME: Always re-build XCTest on non-darwin platforms.
# The Swift project might have been changed, but CMake might
# not be aware and will not rebuild.
echo "Cleaning the libdispatch build directory"
call rm -rf "${LIBDISPATCH_BUILD_DIR}"

Expand Down