Skip to content

Commit 597c4e8

Browse files
authored
Merge pull request #35280 from compnerd/shared-language
ClangImporter: unify language standard selection (NFCI)
2 parents 186717f + d045e48 commit 597c4e8

File tree

1 file changed

+14
-9
lines changed

1 file changed

+14
-9
lines changed

lib/ClangImporter/ClangImporter.cpp

Lines changed: 14 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -520,23 +520,28 @@ importer::getNormalInvocationArguments(
520520
invocationArgStrs.push_back(
521521
"-Werror=non-modular-include-in-framework-module");
522522

523+
bool EnableCXXInterop = LangOpts.EnableCXXInterop;
524+
523525
if (LangOpts.EnableObjCInterop) {
524-
bool EnableCXXInterop = LangOpts.EnableCXXInterop;
525-
invocationArgStrs.insert(
526-
invocationArgStrs.end(),
527-
{"-x", EnableCXXInterop ? "objective-c++" : "objective-c",
528-
EnableCXXInterop ? "-std=gnu++17" : "-std=gnu11", "-fobjc-arc"});
526+
invocationArgStrs.insert(invocationArgStrs.end(), {"-fobjc-arc"});
529527
// TODO: Investigate whether 7.0 is a suitable default version.
530528
if (!triple.isOSDarwin())
531529
invocationArgStrs.insert(invocationArgStrs.end(),
532530
{"-fobjc-runtime=ios-7.0"});
531+
532+
invocationArgStrs.insert(invocationArgStrs.end(), {
533+
"-x", EnableCXXInterop ? "objective-c++" : "objective-c",
534+
});
533535
} else {
534-
bool EnableCXXInterop = LangOpts.EnableCXXInterop;
535-
invocationArgStrs.insert(invocationArgStrs.end(),
536-
{"-x", EnableCXXInterop ? "c++" : "c",
537-
EnableCXXInterop ? "-std=gnu++17" : "-std=gnu11"});
536+
invocationArgStrs.insert(invocationArgStrs.end(), {
537+
"-x", EnableCXXInterop ? "c++" : "c",
538+
});
538539
}
539540

541+
invocationArgStrs.insert(invocationArgStrs.end(), {
542+
EnableCXXInterop ? "-std=gnu++17" : "-std=gnu11",
543+
});
544+
540545
// Set C language options.
541546
if (triple.isOSDarwin()) {
542547
invocationArgStrs.insert(invocationArgStrs.end(), {

0 commit comments

Comments
 (0)