ClangImporter: unify language standard selection (NFCI) #35280
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This simply extracts the shared portion of the language version setup. The state of the ObjC interop determines if we are in ObjectiveC or C mode or ObjectiveC++ or C++ mode depending on C++ interop. However, if Objective-C interop is enabled, we must enable ARC and set the ObjC runtime version according to the target. This simply shares more of the setup and is meant as a simplification for pairing the language version.
|
@swift-ci please clean test |
zoecarver
approved these changes
Jan 6, 2021
|
This is just a cleanup. I wanted to synchronize the clang version and the Swift language version handling (which I have in a subsequent patch). I'll test that, but I suspect that it will resolve the issue on the newer MSVC toolchains. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simply extracts the shared portion of the language version setup.
The state of the ObjC interop determines if we are in ObjectiveC or C
mode or ObjectiveC++ or C++ mode depending on C++ interop. However, if
Objective-C interop is enabled, we must enable ARC and set the ObjC
runtime version according to the target. This simply shares more of the
setup and is meant as a simplification for pairing the language version.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.