Fixing broken tests.

Usage of 'defer' now emits a warning in some places in the tests,
so adding the corresponding 'expected-warning'.

Author: vguerra

test/SILGen/statements.swift

@@ -524,7 +524,7 @@ func defer_in_closure_in_generic<T>(_ x: T) {
   // CHECK-LABEL: sil private @$S10statements017defer_in_closure_C8_genericyyxlFyycfU_ : $@convention(thin) <T> () -> ()
   _ = {
     // CHECK-LABEL: sil private @$S10statements017defer_in_closure_C8_genericyyxlFyycfU_6$deferL_yylF : $@convention(thin) <T> () -> ()
-    defer { generic_callee_1(T.self) }
+    defer { generic_callee_1(T.self) } // expected-warning {{'defer' at the end of its scope is redundant and will execute immediately}}{{5-10=do}}
   }
 }
 
@@ -537,7 +537,7 @@ func defer_mutable(_ x: Int) {
   // CHECK: function_ref @$S10statements13defer_mutableyySiF6$deferL_yyF : $@convention(thin) (@inout_aliasable Int) -> ()
   // CHECK-NOT: [[BOX]]
   // CHECK: destroy_value [[BOX]]
-  defer { _ = x }
+  defer { _ = x } // expected-warning {{'defer' at the end of its scope is redundant and will execute immediately}}{{3-8=do}}
 }
 
 protocol StaticFooProtocol { static func foo() }

test/SILOptimizer/definite_init_diagnostics_globals.swift

@@ -21,7 +21,7 @@ defer { print(y) } // expected-error {{constant 'y' used in defer before being i
 // Test top-level functions.
 
 func testFunc() {       // expected-error {{variable 'x' used by function definition before being initialized}}
-  defer { print(x) }
+  defer { print(x) }    // expected-warning {{'defer' at the end of its scope is redundant and will execute immediately}}{{3-8=do}}
 }
 
 // Test top-level closures.

test/SILOptimizer/unreachable_code.swift

@@ -285,7 +285,7 @@ func deferTryNoReturn() throws {
 }
 
 func noReturnInDefer() {
-  defer {
+  defer { // expected-warning {{'defer' at the end of its scope is redundant and will execute immediately}}{{3-8=do}}
     _ = Lisp()
     die() // expected-note {{a call to a never-returning function}}
     die() // expected-warning {{will never be executed}}

test/stmt/statements.swift

@@ -342,14 +342,17 @@ func test_defer(_ a : Int) {
 
   // Not ok.
   while false { defer { break } }   // expected-error {{'break' cannot transfer control out of a defer statement}}
+  // expected-warning@-1 {{'defer' at the end of its scope is redundant and will execute immediately}}{{17-22=do}}
   defer { return }  // expected-error {{'return' cannot transfer control out of a defer statement}}
+  // expected-warning@-1 {{'defer' at the end of its scope is redundant and will execute immediately}}{{3-8=do}}
 }
 
 class SomeTestClass {
   var x = 42
 
   func method() {
     defer { x = 97 }  // self. not required here!
+    // expected-warning@-1 {{'defer' at the end of its scope is redundant and will execute immediately}}{{5-10=do}}
   }
 }