Skip to content

Commit 7f38662

Browse files
authored
Merge pull request #67801 from meg-gupta/passpipelineassert
Ensure no module transform is added in the high level function pipeline
2 parents c9720ca + 848466a commit 7f38662

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

lib/SILOptimizer/PassManager/PassPipeline.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -637,8 +637,8 @@ static void addPerfEarlyModulePassPipeline(SILPassPipelinePlan &P) {
637637
// callees. This provides more precise escape analysis and side effect analysis
638638
// of callee arguments.
639639
static void addHighLevelFunctionPipeline(SILPassPipelinePlan &P) {
640-
P.startPipeline("HighLevel,Function+EarlyLoopOpt");
641-
// FIXME: update EagerSpecializer to be a function pass!
640+
P.startPipeline("HighLevel,Function+EarlyLoopOpt",
641+
true /*isFunctionPassPipeline*/);
642642
P.addEagerSpecializer();
643643
P.addObjCBridgingOptimization();
644644

lib/SILOptimizer/Transforms/EagerSpecializer.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -745,8 +745,6 @@ SILValue EagerDispatch::emitArgumentConversion(
745745
}
746746

747747
namespace {
748-
// FIXME: This should be a function transform that pushes cloned functions on
749-
// the pass manager worklist.
750748
class EagerSpecializerTransform : public SILFunctionTransform {
751749
bool onlyCreatePrespecializations;
752750
public:

0 commit comments

Comments
 (0)