Skip to content

Ensure no module transform is added in the high level function pipeline #67801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 8, 2023
Merged

Ensure no module transform is added in the high level function pipeline #67801

merged 1 commit into from
Aug 8, 2023

Conversation

meg-gupta
Copy link
Contributor

No description provided.

@meg-gupta
Copy link
Contributor Author

@swift-ci smoke test and merge

nate-chandler
nate-chandler approved these changes Aug 8, 2023
View reviewed changes
Copy link
Contributor

@nate-chandler nate-chandler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the FIXME here can go too:

// FIXME: This should be a function transform that pushes cloned functions on
// the pass manager worklist.
class EagerSpecializerTransform : public SILFunctionTransform {

@meg-gupta meg-gupta force-pushed the passpipelineassert branch from 1880714 to 848466a Compare August 8, 2023 18:05
@meg-gupta
Copy link
Contributor Author

@swift-ci smoke test and merge

@swift-ci swift-ci merged commit 7f38662 into swiftlang:main Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nate-chandler nate-chandler nate-chandler approved these changes

@atrick atrick Awaiting requested review from atrick

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@meg-gupta @nate-chandler @swift-ci