Skip to content

Ensure no module transform is added in the high level function pipeline #67801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 8, 2023
Merged

Ensure no module transform is added in the high level function pipeline #67801

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/SILOptimizer/PassManager/PassPipeline.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -637,8 +637,8 @@ static void addPerfEarlyModulePassPipeline(SILPassPipelinePlan &P) {
// callees. This provides more precise escape analysis and side effect analysis
// of callee arguments.
static void addHighLevelFunctionPipeline(SILPassPipelinePlan &P) {
P.startPipeline("HighLevel,Function+EarlyLoopOpt");
// FIXME: update EagerSpecializer to be a function pass!
P.startPipeline("HighLevel,Function+EarlyLoopOpt",
true /*isFunctionPassPipeline*/);
P.addEagerSpecializer();
P.addObjCBridgingOptimization();

Expand Down
2 changes: 0 additions & 2 deletions lib/SILOptimizer/Transforms/EagerSpecializer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -745,8 +745,6 @@ SILValue EagerDispatch::emitArgumentConversion(
}

namespace {
// FIXME: This should be a function transform that pushes cloned functions on
// the pass manager worklist.
class EagerSpecializerTransform : public SILFunctionTransform {
bool onlyCreatePrespecializations;
public:
Expand Down