Skip to content

Commit 8610b25

Browse files
authored
Merge pull request #68822 from kubamracek/revert-embedded-sdk
Revert "[embedded] Resolve empty -sdk path warning in embedded stdlib build"
2 parents 859dabd + 0962d82 commit 8610b25

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

stdlib/cmake/modules/SwiftSource.cmake

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -230,7 +230,7 @@ function(_add_target_variant_swift_compile_flags
230230
${ARGN})
231231

232232
# On Windows, we don't set SWIFT_SDK_WINDOWS_PATH_ARCH_{ARCH}_PATH, so don't include it.
233-
if ((NOT "${sdk}" STREQUAL "WINDOWS") AND NOT ("${SWIFT_SDK_${sdk}_ARCH_${arch}_PATH}" STREQUAL ""))
233+
if (NOT "${sdk}" STREQUAL "WINDOWS")
234234
list(APPEND result "-sdk" "${SWIFT_SDK_${sdk}_ARCH_${arch}_PATH}")
235235
endif()
236236

stdlib/public/core/CMakeLists.txt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -420,15 +420,14 @@ if(SWIFT_SHOULD_BUILD_EMBEDDED_STDLIB)
420420

421421
set(SWIFT_SDK_embedded_ARCH_${arch}_MODULE "${mod}")
422422
set(SWIFT_SDK_embedded_LIB_SUBDIR "embedded")
423-
set(SWIFT_SDK_embedded_ARCH_${arch}_TRIPLE "${triple}")
424423
add_swift_target_library_single(
425424
embedded-stdlib-${triple}
426425
swiftCore
427426
ONLY_SWIFTMODULE
428427
IS_STDLIB IS_STDLIB_CORE
429428
${SWIFTLIB_EMBEDDED_SOURCES}
430429
GYB_SOURCES ${SWIFTLIB_EMBEDDED_GYB_SOURCES}
431-
SWIFT_COMPILE_FLAGS -Xcc -D__MACH__ -enable-experimental-feature Embedded
430+
SWIFT_COMPILE_FLAGS -target "${triple}" -Xcc -D__MACH__ -enable-experimental-feature Embedded
432431
MODULE_DIR "${CMAKE_BINARY_DIR}/lib/swift/embedded"
433432
SDK "embedded"
434433
ARCHITECTURE "${arch}"

0 commit comments

Comments
 (0)