Skip to content

Commit a550fa8

Browse files
authored
Merge pull request #67038 from rintaro/5.9-macros-public-message
[5.9][Macros] Unify PluginMessages.swift
2 parents 5c5bb1e + a1b08e9 commit a550fa8

File tree

6 files changed

+11
-194
lines changed

6 files changed

+11
-194
lines changed

lib/ASTGen/CMakeLists.txt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ add_pure_swift_host_library(swiftASTGen STATIC
1515
Sources/ASTGen/Macros.swift
1616
Sources/ASTGen/Misc.swift
1717
Sources/ASTGen/PluginHost.swift
18-
Sources/ASTGen/PluginMessages.swift
1918
Sources/ASTGen/SourceFile.swift
2019
Sources/ASTGen/SourceManager.swift
2120
Sources/ASTGen/SourceManager+MacroExpansionContext.swift
@@ -26,11 +25,13 @@ add_pure_swift_host_library(swiftASTGen STATIC
2625
swiftAST
2726
SWIFT_DEPENDENCIES
2827
SwiftSyntax::SwiftBasicFormat
28+
SwiftSyntax::SwiftCompilerPluginMessageHandling
2929
SwiftSyntax::SwiftDiagnostics
3030
SwiftSyntax::SwiftOperators
3131
SwiftSyntax::SwiftParser
3232
SwiftSyntax::SwiftParserDiagnostics
3333
SwiftSyntax::SwiftSyntax
34+
SwiftSyntax::SwiftSyntaxBuilder
3435
SwiftSyntax::SwiftSyntaxMacros
3536
SwiftSyntax::SwiftSyntaxMacroExpansion
3637
swiftLLVMJSON

lib/ASTGen/Package.swift

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,10 +32,14 @@ let package = Package(
3232
.target(
3333
name: "swiftASTGen",
3434
dependencies: [
35+
.product(name: "SwiftBasicFormat", package: "swift-syntax"),
36+
.product(name: "SwiftCompilerPluginMessageHandling", package: "swift-syntax"),
3537
.product(name: "SwiftDiagnostics", package: "swift-syntax"),
36-
.product(name: "SwiftSyntax", package: "swift-syntax"),
3738
.product(name: "SwiftOperators", package: "swift-syntax"),
3839
.product(name: "SwiftParser", package: "swift-syntax"),
40+
.product(name: "SwiftParserDiagnostics", package: "swift-syntax"),
41+
.product(name: "SwiftSyntax", package: "swift-syntax"),
42+
.product(name: "SwiftSyntaxBuilder", package: "swift-syntax"),
3943
.product(name: "SwiftSyntaxMacros", package: "swift-syntax"),
4044
.product(name: "SwiftSyntaxMacroExpansion", package: "swift-syntax"),
4145
"swiftLLVMJSON"

lib/ASTGen/Sources/ASTGen/Macros.swift

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,10 @@ import SwiftDiagnostics
1515
import SwiftOperators
1616
import SwiftParser
1717
import SwiftSyntax
18+
import SwiftSyntaxBuilder
1819
import SwiftSyntaxMacros
1920
import SwiftSyntaxMacroExpansion
21+
@_spi(PluginMessage) import SwiftCompilerPluginMessageHandling
2022

2123
extension SyntaxProtocol {
2224
func token(at position: AbsolutePosition) -> TokenSyntax? {
@@ -829,7 +831,6 @@ func expandAttachedMacroIPC(
829831
macro: .init(moduleName: macro.moduleName, typeName: macro.typeName, name: macroName),
830832
macroRole: macroRole,
831833
discriminator: discriminator,
832-
qualifiedType: qualifiedType,
833834
attributeSyntax: customAttributeSyntax,
834835
declSyntax: declSyntax,
835836
parentDeclSyntax: parentDeclSyntax,

lib/ASTGen/Sources/ASTGen/PluginHost.swift

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ import CASTBridging
1414
import CBasicBridging
1515
import SwiftSyntax
1616
import swiftLLVMJSON
17+
@_spi(PluginMessage) import SwiftCompilerPluginMessageHandling
1718

1819
enum PluginError: String, Error, CustomStringConvertible {
1920
case stalePlugin = "plugin is stale"

lib/ASTGen/Sources/ASTGen/PluginMessages.swift

Lines changed: 0 additions & 190 deletions
This file was deleted.

test/Macros/macro_plugin_error.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ func test() {
4040
// FIXME: Should be more user friendly message.
4141

4242
let _: String = #fooMacro(1)
43-
// expected-error @-1 {{typeMismatch(swiftASTGen.PluginToHostMessage}}
43+
// expected-error @-1 {{typeMismatch(SwiftCompilerPluginMessageHandling.PluginToHostMessage}}
4444
let _: String = #fooMacro(2)
4545
// expected-error @-1 {{failed to receive result from plugin (from macro 'fooMacro')}}
4646
let _: String = #fooMacro(3)

0 commit comments

Comments
 (0)