Skip to content

Commit a649260

Browse files
authored
Merge pull request #61860 from atrick/fix-data-bench
Skip DataReplaceLargeBuffer benchmark by default.
2 parents 33d178c + f011020 commit a649260

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

benchmark/single-source/DataBenchmarks.swift

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -178,8 +178,10 @@ public let benchmarks = [
178178
replaceBuffer($0*100, data: medium, subrange:431..<809, with: medium) },
179179
tags: d, legacyFactor: 100),
180180
BenchmarkInfo(name: "DataReplaceLargeBuffer", runFunction: {
181-
replaceBuffer($0*10, data: medium, subrange:431..<809, with: large) },
182-
tags: d),
181+
replaceBuffer($0*100, data: medium, subrange:431..<809, with: large) },
182+
tags: d + [.skip]),
183+
// Large buffer replacement is too dependent on the system state
184+
// to produce a meaningful benchmark score. 30% variation is common.
183185

184186
BenchmarkInfo(name: "DataAppendSequence",
185187
runFunction: { append($0*100, sequenceLength: 809, to: medium) },

0 commit comments

Comments
 (0)