Skip to content

Skip DataReplaceLargeBuffer benchmark by default. #61860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 2, 2022

Conversation

atrick
Copy link
Contributor

@atrick atrick commented Nov 2, 2022

Large buffer replacement is too dependent on the system state to produce a meaningful benchmark score. 30% variation is common.

Increasing the inner loop trip count has no effect on stability.

Large buffer replacement is too dependent on the system state
to produce a meaningful benchmark score. 30% variation is common.
@atrick atrick requested a review from tbkka November 2, 2022 01:03
@atrick
Copy link
Contributor Author

atrick commented Nov 2, 2022

@swift-ci smoke test

@atrick
Copy link
Contributor Author

atrick commented Nov 2, 2022

@swift-ci benchmark

@CodaFi
Copy link
Contributor

CodaFi commented Nov 2, 2022

@swift-ci smoke test

@atrick atrick merged commit a649260 into swiftlang:main Nov 2, 2022
@atrick atrick deleted the fix-data-bench branch November 2, 2022 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants