Skip to content

Commit c051af4

Browse files
authored
[AutoDiff] NFC: Highlights original function name in diagnostic (#36259)
Small follow up of [PR-36128](#36128) to be consistent with other diagnostics emitted when type-checking `@derivative` and `@transpose` attributes.
1 parent f103d2e commit c051af4

File tree

1 file changed

+8
-5
lines changed

1 file changed

+8
-5
lines changed

lib/Sema/TypeCheckAttr.cpp

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4843,10 +4843,12 @@ static bool typeCheckDerivativeAttr(ASTContext &Ctx, Decl *D,
48434843
// Diagnose if original function and derivative differ in terms of static declaration.
48444844
if (!compatibleStaticDecls()) {
48454845
bool derivativeMustBeStatic = !derivative->isStatic();
4846-
diags.diagnose(attr->getOriginalFunctionName().Loc.getBaseNameLoc(),
4847-
diag::derivative_attr_static_method_mismatch_original,
4848-
originalAFD->getName(), derivative->getName(),
4849-
derivativeMustBeStatic);
4846+
diags
4847+
.diagnose(attr->getOriginalFunctionName().Loc.getBaseNameLoc(),
4848+
diag::derivative_attr_static_method_mismatch_original,
4849+
originalAFD->getName(), derivative->getName(),
4850+
derivativeMustBeStatic)
4851+
.highlight(attr->getOriginalFunctionName().Loc.getSourceRange());
48504852
diags.diagnose(originalAFD->getNameLoc(),
48514853
diag::derivative_attr_static_method_mismatch_original_note,
48524854
originalAFD->getName(), derivativeMustBeStatic);
@@ -5393,7 +5395,8 @@ void AttributeChecker::visitTransposeAttr(TransposeAttr *attr) {
53935395
diagnose(attr->getOriginalFunctionName().Loc.getBaseNameLoc(),
53945396
diag::transpose_attr_static_method_mismatch_original,
53955397
originalAFD->getName(), transpose->getName(),
5396-
transposeMustBeStatic);
5398+
transposeMustBeStatic)
5399+
.highlight(attr->getOriginalFunctionName().Loc.getSourceRange());
53975400
diagnose(originalAFD->getNameLoc(),
53985401
diag::transpose_attr_static_method_mismatch_original_note,
53995402
originalAFD->getName(), transposeMustBeStatic);

0 commit comments

Comments
 (0)