Skip to content

[AutoDiff] NFC: Highlights original function name in diagnostic #36259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 5, 2021

Conversation

vguerra
Copy link
Contributor

@vguerra vguerra commented Mar 3, 2021

Small follow up of PR-36128 to be consistent with other diagnostics emitted when type-checking @derivative and @transpose attributes.

Small follow up of [PR-36128](swiftlang#36128)
to be consistent with other diagnostics emitted when type-checking
`@derivative` and `@transpose` attributes.
@rxwei
Copy link
Contributor

rxwei commented Mar 3, 2021

@swift-ci please test and merge

@vguerra
Copy link
Contributor Author

vguerra commented Mar 4, 2021

The failure for Swift Test macOS Platform seems unrelated to this change:

20:55:34 FATAL: Unable to delete script file /var/folders/_8/79jmzf2142z2xydc_01btlx00000gn/T/jenkins7093808389191469028.sh
20:55:34 java.io.EOFException
20:55:34 at java.io.ObjectInputStream$PeekInputStream.readFully(ObjectInputStream.java:2759)
20:55:34 at java.io.ObjectInputStream$BlockDataInputStream.readShort(ObjectInputStream.java:3234)
20:55:34 at java.io.ObjectInputStream.readStreamHeader(ObjectInputStream.java:913)
20:55:34 at java.io.ObjectInputStream.(ObjectInputStream.java:375)
20:55:34 at hudson.remoting.ObjectInputStreamEx.(ObjectInputStreamEx.java:49)
20:55:34 at hudson.remoting.Command.readFrom(Command.java:142)
20:55:34 at hudson.remoting.Command.readFrom(Command.java:128)
20:55:34 at hudson.remoting.AbstractSynchronousByteArrayCommandTransport.read(AbstractSynchronousByteArrayCommandTransport.java:35)
20:55:34 at hudson.remoting.SynchronousCommandTransport$ReaderThread.run(SynchronousCommandTransport.java:63)
20:55:34 Caused: java.io.IOException: Unexpected termination of the channel
20:55:34 at hudson.remoting.SynchronousCommandTransport$ReaderThread.run(SynchronousCommandTransport.java:77)
20:55:34 Caused: hudson.remoting.ChannelClosedException: Channel "hudson.remoting.Channel@4c22fd22:macOS-44": Remote call on macOS-44 failed. The channel is closing down or has closed down
20:55:34 at hudson.remoting.Channel.call(Channel.java:991)

could you please comment again to trigger again the tests?

@rxwei
Copy link
Contributor

rxwei commented Mar 4, 2021

@swift-ci please test macos

@rxwei rxwei merged commit c051af4 into swiftlang:main Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants