Merge pull request #23024 from palimondo/against-the-dark

[Gardening] Remove DoubleWidth related dead code

Author: palimondo

benchmark/CMakeLists.txt

@@ -77,7 +77,6 @@ set(SWIFT_BENCH_MODULES
     single-source/DictionaryRemove
     single-source/DictionarySubscriptDefault
     single-source/DictionarySwap
-    single-source/DoubleWidthDivision
     single-source/DropFirst
     single-source/DropLast
     single-source/DropWhile

benchmark/single-source/DoubleWidthDivision.swift

@@ -65,7 +65,6 @@ import DictionaryOfAnyHashableStrings
 import DictionaryRemove
 import DictionarySubscriptDefault
 import DictionarySwap
-import DoubleWidthDivision
 import DropFirst
 import DropLast
 import DropWhile
@@ -235,7 +234,6 @@ registerBenchmark(DictionaryOfAnyHashableStrings)
 registerBenchmark(DictionaryRemove)
 registerBenchmark(DictionarySubscriptDefault)
 registerBenchmark(DictionarySwap)
-registerBenchmark(DoubleWidthDivision)
 registerBenchmark(DropFirst)
 registerBenchmark(DropLast)
 registerBenchmark(DropWhile)

benchmark/utils/main.swift

@@ -54,5 +54,3 @@ class R<K: Hashable, V> {
 infix operator +=+ : AdditionPrecedence
 func +=+(_ lhs: Int, _ rhs: Int) -> Bool { return lhs == rhs }
 func +=+<T: BinaryInteger>(_ lhs: T, _ rhs: Int) -> Bool { return lhs == rhs }
-// FIXME: DoubleWidth is no longer part of the standard library
-// let _ = DoubleWidth<Int>(Int.min) - 1 +=+ Int.min // Ok

test/Constraints/diagnostics_swift4.swift

@@ -4,6 +4,10 @@
 
 import StdlibUnittest
 
+// XXX: Auxiliary tests & benchmark for DoubleWidth were removed in PR #23024.
+// When the DoubleWidth makes comeback, revert the commits from there to
+// ressurect what was just a dead code in the meantime…
+
 /// A fixed-width integer that has twice the bit width of its base type.
 ///
 /// You can use the `DoubleWidth` type to continue calculations with the result

test/Prototypes/DoubleWidth.swift.gyb

@@ -112,14 +112,6 @@ FloatingPoint.test("BinaryFloatingPoint/genericIntegerConversion") {
   expectEqual(Float._convert(from: Int64.max).value, Float(Int64.max))
   expectEqual(Float._convert(from: Int64.min).value, Float(Int64.min))
 
-// FIXME: DoubleWidth is no longer part of the standard library
-#if false
-  expectEqual(Float._convert(from: DoubleWidth<UInt64>.max).value, .infinity)
-  expectEqual(
-    Float._convert(from: DoubleWidth<DoubleWidth<Int64>>.max).value, .infinity)
-  expectEqual(
-    Float._convert(from: DoubleWidth<DoubleWidth<Int64>>.min).value, -.infinity)
-#endif
 }
 
 FloatingPoint.test("BinaryFloatingPoint/genericFloatingPointConversion") {

test/stdlib/FloatingPoint.swift.gyb

@@ -914,18 +914,6 @@ tests.test("binaryLogarithm/generic") {
   expectEqual(
     (42 as MockBinaryInteger<UInt>)._binaryLogarithm(),
     (42 as UInt)._binaryLogarithm())
-// FIXME: DoubleWidth is no longer part of the standard library
-#if false
-  expectEqual(
-    (42 as MockBinaryInteger<DoubleWidth<Int>>)._binaryLogarithm(),
-    (42 as DoubleWidth<Int>)._binaryLogarithm())
-  expectEqual(
-    (42 as MockBinaryInteger<DoubleWidth<UInt>>)._binaryLogarithm(),
-    (42 as DoubleWidth<UInt>)._binaryLogarithm())
-  expectEqual(
-    (42 as MockBinaryInteger<DoubleWidth<DoubleWidth<Int>>>)._binaryLogarithm(),
-    (42 as DoubleWidth<DoubleWidth<Int>>)._binaryLogarithm())
-#endif
 }
 
 runAllTests()