Skip to content

Commit d012208

Browse files
authored
Merge pull request #39933 from DougGregor/back-deploy-fix-bundle-identifier
2 parents 0a7272b + 6d0abdf commit d012208

File tree

2 files changed

+11
-1
lines changed

2 files changed

+11
-1
lines changed

stdlib/cmake/modules/AddSwiftStdlib.cmake

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1263,7 +1263,9 @@ function(add_swift_target_library_single target name)
12631263
set(PLIST_INFO_PLIST "Info.plist" CACHE STRING "Plist name")
12641264
if("${SWIFTLIB_SINGLE_SDK}" IN_LIST SWIFT_DARWIN_PLATFORMS AND SWIFTLIB_SINGLE_IS_STDLIB)
12651265
set(PLIST_INFO_NAME ${name})
1266-
set(PLIST_INFO_UTI "com.apple.dt.runtime.${name}")
1266+
1267+
# Underscores aren't permitted in the bundle identifier.
1268+
string(REPLACE "_" "" PLIST_INFO_UTI "com.apple.dt.runtime.${name}")
12671269
set(PLIST_INFO_VERSION "${SWIFT_VERSION}")
12681270
if (SWIFT_COMPILER_VERSION)
12691271
set(PLIST_INFO_BUILD_VERSION

utils/swift_build_support/swift_build_support/products/backdeployconcurrency.py

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,14 @@ def build(self, host_target):
8484
self.cmake_options.define('SWIFT_HOST_VARIANT_ARCH:STRING', arch)
8585
self.cmake_options.define('BUILD_STANDALONE:BOOL', True)
8686

87+
# Propagate version information
88+
if self.args.swift_user_visible_version is not None:
89+
self.cmake_options.define('SWIFT_VERSION',
90+
str(self.args.swift_user_visible_version))
91+
if self.args.swift_compiler_version is not None:
92+
self.cmake_options.define('SWIFT_COMPILER_VERSION',
93+
str(self.args.swift_compiler_version))
94+
8795
# Only install the "stdlib" component, which contains the concurrency
8896
# module.
8997
self.cmake_options.define('SWIFT_INSTALL_COMPONENTS:STRING', 'back-deployment')

0 commit comments

Comments
 (0)