Skip to content

Fix embedded plist of back-deployed concurrency library #39933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 27, 2021

Conversation

DougGregor
Copy link
Member

@DougGregor DougGregor commented Oct 27, 2021

Fix two issues with the embedded plist for the back-deployed concurrency library:

  • Remove underscores from CFBundleIdentifier of libraries, because they're not permitted in the reverse-DNS name there.
  • Propagate Swift version information to the back-deployed binaries, because it's better than leaving it empty.

Fixes rdar://84645973.

@DougGregor
Copy link
Member Author

@swift-ci please smoke test and merge

@DougGregor
Copy link
Member Author

@swift-ci please smoke test and merge

@swift-ci swift-ci merged commit d012208 into swiftlang:main Oct 27, 2021
@DougGregor DougGregor deleted the back-deploy-fix-bundle-identifier branch October 27, 2021 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants