Skip to content

Commit dc762c6

Browse files
authored
Merge pull request #7775 from compnerd/IndexType
Basic: use IndexType instead of unsigned
2 parents ba27536 + edc3031 commit dc762c6

File tree

2 files changed

+23
-14
lines changed

2 files changed

+23
-14
lines changed

lib/Basic/Demangle.cpp

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -628,11 +628,13 @@ class OldDemangler {
628628

629629
/// TODO: This is an atrocity. Come up with a shorter name.
630630
#define FUNCSIGSPEC_CREATE_PARAM_KIND(kind) \
631-
Factory.createNode(Node::Kind::FunctionSignatureSpecializationParamKind, \
632-
uint64_t(FunctionSigSpecializationParamKind::kind))
631+
Factory.createNode( \
632+
Node::Kind::FunctionSignatureSpecializationParamKind, \
633+
Node::IndexType(FunctionSigSpecializationParamKind::kind))
634+
633635
#define FUNCSIGSPEC_CREATE_PARAM_PAYLOAD(payload) \
634-
Factory.createNode(Node::Kind::FunctionSignatureSpecializationParamPayload, \
635-
payload)
636+
Factory.createNode(Node::Kind::FunctionSignatureSpecializationParamPayload, \
637+
payload)
636638

637639
bool demangleFuncSigSpecializationConstantProp(NodePointer parent) {
638640
// Then figure out what was actually constant propagated. First check if

lib/Basic/Demangler.cpp

Lines changed: 17 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1417,14 +1417,19 @@ NodePointer Demangler::demangleFuncSpecParam(Node::IndexType ParamIdx) {
14171417
switch (nextChar()) {
14181418
case 'f':
14191419
// Consumes an identifier parameter, which will be added later.
1420-
return addChild(Param, createNode(
1421-
Node::Kind::FunctionSignatureSpecializationParamKind,
1422-
uint64_t(FunctionSigSpecializationParamKind::ConstantPropFunction)));
1420+
return addChild(
1421+
Param,
1422+
createNode(Node::Kind::FunctionSignatureSpecializationParamKind,
1423+
Node::IndexType(FunctionSigSpecializationParamKind::
1424+
ConstantPropFunction)));
14231425
case 'g':
14241426
// Consumes an identifier parameter, which will be added later.
1425-
return addChild(Param, createNode(
1426-
Node::Kind::FunctionSignatureSpecializationParamKind,
1427-
uint64_t(FunctionSigSpecializationParamKind::ConstantPropGlobal)));
1427+
return addChild(
1428+
Param,
1429+
createNode(
1430+
Node::Kind::FunctionSignatureSpecializationParamKind,
1431+
Node::IndexType(
1432+
FunctionSigSpecializationParamKind::ConstantPropGlobal)));
14281433
case 'i':
14291434
return addFuncSpecParamNumber(Param,
14301435
FunctionSigSpecializationParamKind::ConstantPropInteger);
@@ -1441,10 +1446,12 @@ NodePointer Demangler::demangleFuncSpecParam(Node::IndexType ParamIdx) {
14411446
case 'c': Encoding = "objc"; break;
14421447
default: return nullptr;
14431448
}
1444-
addChild(Param, createNode(
1445-
Node::Kind::FunctionSignatureSpecializationParamKind,
1446-
unsigned(swift::Demangle::FunctionSigSpecializationParamKind::
1447-
ConstantPropString)));
1449+
addChild(Param,
1450+
createNode(
1451+
Node::Kind::FunctionSignatureSpecializationParamKind,
1452+
Node::IndexType(
1453+
swift::Demangle::FunctionSigSpecializationParamKind::
1454+
ConstantPropString)));
14481455
return addChild(Param, createNode(
14491456
Node::Kind::FunctionSignatureSpecializationParamPayload,
14501457
Encoding));

0 commit comments

Comments
 (0)