Skip to content

Basic: use IndexType instead of unsigned #7775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 28, 2017
Merged

Conversation

compnerd
Copy link
Member

Explicitly specify the aliased type (IndexType) rather than the
underlying type (unsigned) when invoking CreateNode to disambiguate
overload when targeting Windows. NFC.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

Explicitly specify the aliased type (IndexType) rather than the
underlying type (unsigned) when invoking `CreateNode` to disambiguate
overload when targeting Windows.  NFC.
@compnerd
Copy link
Member Author

@swift-ci please test and merge

@hughbe
Copy link
Contributor

hughbe commented Feb 27, 2017

Sorry! I caused a merge conflict here - trying to resolve it through the GitHub UI to ease your work didn't work :(

@hughbe
Copy link
Contributor

hughbe commented Feb 27, 2017

@swift-ci please smoke test

@swift-ci
Copy link
Contributor

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - 44ffe01
Test requested by - @hughbe

@swift-ci
Copy link
Contributor

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - 44ffe01
Test requested by - @hughbe

@hughbe
Copy link
Contributor

hughbe commented Feb 27, 2017

@swift-ci please smoke test

@hughbe
Copy link
Contributor

hughbe commented Feb 27, 2017

Here's a simple reproduction:

void addChild(uint64_t) { std::cout << "1"; }
void addChild(const char*) { std::cout << "2"; }

int main() { addChild(unsigned(0)); }

This looks like a Clang bug - GCC/MSVC reject this correctly.

@hughbe
Copy link
Contributor

hughbe commented Feb 27, 2017

Opened http://bugs.llvm.org/show_bug.cgi?id=32073, obviously a breaking change - I suggested a warning instead of an error

@compnerd
Copy link
Member Author

@swift-ci please test and merge

@compnerd
Copy link
Member Author

@swift-ci please test OS X platform

@compnerd
Copy link
Member Author

@swift-ci please test Linux platform

@swift-ci
Copy link
Contributor

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - edc3031
Test requested by - @compnerd

@compnerd
Copy link
Member Author

@swift-ci please test Linux platform

@compnerd compnerd merged commit dc762c6 into swiftlang:master Feb 28, 2017
@compnerd compnerd deleted the IndexType branch February 28, 2017 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants