-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Basic: use IndexType instead of unsigned #7775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Explicitly specify the aliased type (IndexType) rather than the underlying type (unsigned) when invoking `CreateNode` to disambiguate overload when targeting Windows. NFC.
@swift-ci please test and merge |
Sorry! I caused a merge conflict here - trying to resolve it through the GitHub UI to ease your work didn't work :( |
@swift-ci please smoke test |
Build failed |
Build failed |
@swift-ci please smoke test |
Here's a simple reproduction:
This looks like a Clang bug - GCC/MSVC reject this correctly. |
Opened http://bugs.llvm.org/show_bug.cgi?id=32073, obviously a breaking change - I suggested a warning instead of an error |
@swift-ci please test and merge |
@swift-ci please test OS X platform |
@swift-ci please test Linux platform |
Build failed |
@swift-ci please test Linux platform |
Explicitly specify the aliased type (IndexType) rather than the
underlying type (unsigned) when invoking
CreateNode
to disambiguateoverload when targeting Windows. NFC.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.