Skip to content

Commit dce480a

Browse files
authored
Merge pull request #42364 from apple/egorzhdan/libstdcxx-centos-test-fix
[cxx-interop] Fix libstdc++ test failure with CentOS 7
2 parents 1b85082 + 2131d20 commit dce480a

File tree

2 files changed

+11
-16
lines changed

2 files changed

+11
-16
lines changed
Lines changed: 10 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
// RUN: %empty-directory(%t)
22
// RUN: %target-swift-ide-test -print-module -module-to-print=std -source-filename=x -enable-experimental-cxx-interop -module-cache-path %t > %t/interface.swift
33
// RUN: %FileCheck %s -check-prefix=CHECK-STD < %t/interface.swift
4+
// RUN: %FileCheck %s -check-prefix=CHECK-SIZE-T < %t/interface.swift
45
// RUN: %FileCheck %s -check-prefix=CHECK-TO-STRING < %t/interface.swift
56
// RUN: %FileCheck %s -check-prefix=CHECK-STRING < %t/interface.swift
67

@@ -9,23 +10,19 @@
910
// This test is specific to libstdc++ and only runs on platforms where libstdc++ is used.
1011
// REQUIRES: OS=linux-gnu
1112

12-
// REQUIRES: rdar91670704
13-
1413
// CHECK-STD: enum std {
15-
// CHECK-STD: enum __cxx11 {
16-
// CHECK-STD: struct __CxxTemplateInstNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEE {
17-
// CHECK-STD: typealias value_type = std.__CxxTemplateInstSt11char_traitsIcE.char_type
18-
// CHECK-STD: }
19-
// CHECK-STD: struct __CxxTemplateInstNSt7__cxx1112basic_stringIwSt11char_traitsIwESaIwEEE {
20-
// CHECK-STD: typealias value_type = std.__CxxTemplateInstSt11char_traitsIwE.char_type
21-
// CHECK-STD: }
22-
// CHECK-STD: }
14+
// CHECK-STRING: struct {{__CxxTemplateInstNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEE|__CxxTemplateInstSs}} {
15+
// CHECK-STRING: typealias value_type = std.__CxxTemplateInstSt11char_traitsIcE.char_type
16+
// CHECK-STRING: }
17+
// CHECK-STRING: struct {{__CxxTemplateInstNSt7__cxx1112basic_stringIwSt11char_traitsIwESaIwEEE|__CxxTemplateInstSbIwSt11char_traitsIwESaIwEE}} {
18+
// CHECK-STRING: typealias value_type = std.__CxxTemplateInstSt11char_traitsIwE.char_type
19+
// CHECK-STRING: }
2320

2421
// CHECK-TO-STRING: static func to_string(_ __val: Int32) -> std{{(.__cxx11)?}}.string
2522
// CHECK-TO-STRING: static func to_wstring(_ __val: Int32) -> std{{(.__cxx11)?}}.wstring
2623

27-
// CHECK-STD: typealias size_t = Int
24+
// CHECK-SIZE-T: typealias size_t = Int
2825

29-
// CHECK-STRING: typealias string = std.__cxx11.__CxxTemplateInstNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEE
30-
// CHECK-STRING: typealias wstring = std.__cxx11.__CxxTemplateInstNSt7__cxx1112basic_stringIwSt11char_traitsIwESaIwEEE
26+
// CHECK-STRING: typealias string = std.{{__cxx11.__CxxTemplateInstNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEE|__CxxTemplateInstSs}}
27+
// CHECK-STRING: typealias wstring = std.{{__cxx11.__CxxTemplateInstNSt7__cxx1112basic_stringIwSt11char_traitsIwESaIwEEE|__CxxTemplateInstSbIwSt11char_traitsIwESaIwEE}}
3128
// CHECK-STD: }

test/Interop/Cxx/stdlib/use-std-string.swift

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,6 @@
55
// Enable this everywhere once we have a solution for modularizing other C++ stdlibs: rdar://87654514
66
// REQUIRES: OS=macosx || OS=linux-gnu
77

8-
// REQUIRES: rdar91548568
9-
108
import StdlibUnittest
119
import StdString
1210
#if os(Linux)
@@ -19,7 +17,7 @@ import std.string
1917
var StdStringTestSuite = TestSuite("StdString")
2018

2119
StdStringTestSuite.test("init") {
22-
let s = CxxString()
20+
var s = CxxString() // declared as `var` because of outdated libstdc++ on CentOS 7
2321
expectEqual(s.size(), 0)
2422
expectTrue(s.empty())
2523
}

0 commit comments

Comments
 (0)