[cxx-interop] Fix libstdc++ test failure with CentOS 7 #42364
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CentOS 7 comes with an outdated libstdc++ version. In that version, `std::basic_string` has a `mutable` member, which makes all of `basic_string`'s member functions mutating in Swift. This prevents us from calling `size()` or `empty()` on an immutable value of `std.string`. rdar://91548568 rdar://91670704
|
@swift-ci please smoke test |
|
@swift-ci please test CentOS 7 platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes
use-std-string.swift&libstdcxx-module-interface.swift.CentOS 7 comes with an outdated libstdc++ version. In that version,
std::basic_stringhas amutablemember, which makes all ofbasic_string's member functions mutating in Swift. This prevents us from callingsize()orempty()on an immutable value ofstd.string. We should force these methods to be imported as non-mutating in Swift, but for now let's usevarto make the tests pass.rdar://91548568
rdar://91670704