Merge pull request #64503 from ahoppen/ahoppen/macro-call-arg-completion

[CodeCompletion] Fix assertion failure if completing in a macro call argument

Author: ahoppen

lib/Parse/ParseExpr.cpp

@@ -3391,8 +3391,6 @@ ParserResult<Expr> Parser::parseExprMacroExpansion(bool isExprBasic) {
   if (Tok.isFollowingLParen()) {
     auto result = parseArgumentList(tok::l_paren, tok::r_paren, isExprBasic,
                                 /*allowTrailingClosure*/ true);
-    if (result.hasCodeCompletion())
-      return makeParserCodeCompletionResult<Expr>();
     argList = result.getPtrOrNull();
     status |= result;
   } else if (Tok.is(tok::l_brace) &&

test/IDE/complete_call_arg.swift

@@ -1419,3 +1419,22 @@ func testRdar89773376(arry: [Int]) {
 // RDAR89773376-DAG: Decl[Constructor]/CurrNominal/Flair[ArgLabels]: ['(']{#intVal: Int#}[')'][#Rdar89773376#];
 // RDAR89773376: End completions
 }
+
+// This is an incomplete macro definition but it's sufficient to get the signature for code completion purposes
+@freestanding(expression)
+macro MyMacro(myArg: Int)
+
+func testMacroCallPattern() {
+  #MyMacro(#^MACRO_CALL_PATTERN^#
+// MACRO_CALL_PATTERN: Begin completions, 1 items
+// MACRO_CALL_PATTERN: Pattern/CurrModule/Flair[ArgLabels]: ['(']{#myArg: Int#}[')'][#Void#]; name=myArg:
+// MACRO_CALL_PATTERN: End completions
+}
+
+func testMacroArg() {
+  #MyMacro(myArg: #^MACRO_CALL_ARG^#
+// MACRO_CALL_ARG: Begin completions
+// MACRO_CALL_ARG-DAG: Literal[Integer]/None/TypeRelation[Convertible]: 0[#Int#]; name=0
+// MACRO_CALL_ARG-DAG: Literal[Boolean]/None:              true[#Bool#]; name=true
+// MACRO_CALL_ARG: End completions
+}