[CodeCompletion] Fix assertion failure if completing in a macro call argument #64503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
requested review from
bnbarham,
CodaFi,
DougGregor and
rintaro
as code owners
|
@swift-ci Please smoke test |
bnbarham
approved these changes
Mar 21, 2023
test/IDE/complete_call_arg.swift
Outdated
| @@ -1419,3 +1419,22 @@ func testRdar89773376(arry: [Int]) { | |||
| // RDAR89773376-DAG: Decl[Constructor]/CurrNominal/Flair[ArgLabels]: ['(']{#intVal: Int#}[')'][#Rdar89773376#]; | |||
| // RDAR89773376: End completions | |||
| } | |||
|
|
|||
| // This is in incomplete macro definition but it's sufficient to get the signature for code completion purposes | |||
There was a problem hiding this comment.
nit pick: in -> an
Suggested change
| // This is in incomplete macro definition but it's sufficient to get the signature for code completion purposes | |
| // This is an incomplete macro definition but it's sufficient to get the signature for code completion purposes |
…argument rdar://106966610
ahoppen
force-pushed
the
ahoppen/macro-call-arg-completion
branch
from
26305c4 to
35871c2
Compare
|
@swift-ci Please clean smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rdar://106966610