Merge pull request #36270 from rintaro/ast-getserializedlocs-rdar75010520

[AST] Only use serialized locs for 'getRawComment()' in symbol graph

Author: rintaro

include/swift/AST/Decl.h

@@ -877,7 +877,7 @@ class alignas(1 << DeclAlignInBits) Decl {
   }
 
   /// \returns the unparsed comment attached to this declaration.
-  RawComment getRawComment(bool SerializedOK = true) const;
+  RawComment getRawComment(bool SerializedOK = false) const;
 
   Optional<StringRef> getGroupName() const;
 

lib/AST/Decl.cpp

@@ -602,6 +602,9 @@ const Decl::CachedExternalSourceLocs *Decl::getSerializedLocs() const {
     return CachedSerializedLocs;
   }
   auto *File = cast<FileUnit>(getDeclContext()->getModuleScopeContext());
+  assert(File->getKind() == FileUnitKind::SerializedAST &&
+         "getSerializedLocs() should only be called on decls in "
+         "a 'SerializedASTFile'");
   auto Locs = File->getBasicLocsForDecl(this);
   if (!Locs.hasValue()) {
     static const Decl::CachedExternalSourceLocs NullLocs{};

lib/AST/DocComment.cpp

@@ -440,7 +440,7 @@ const ValueDecl *findRequirementDeclWithDocComment(const ValueDecl *VD,
   std::queue<const ValueDecl *> requirements;
   while (true) {
     for (auto *req : VD->getSatisfiedProtocolRequirements()) {
-      if (!req->getRawComment().isEmpty())
+      if (!req->getRawComment(AllowSerialized).isEmpty())
         return req;
       else
         requirements.push(req);

lib/AST/RawComment.cpp

@@ -147,9 +147,14 @@ RawComment Decl::getRawComment(bool SerializedOK) const {
     return Result;
   }
 
-  // Ask the parent module.
-  if (auto *Unit =
-          dyn_cast<FileUnit>(this->getDeclContext()->getModuleScopeContext())) {
+  if (!getDeclContext())
+    return RawComment();
+  auto *Unit = dyn_cast<FileUnit>(getDeclContext()->getModuleScopeContext());
+  if (!Unit)
+    return RawComment();
+
+  switch (Unit->getKind()) {
+  case FileUnitKind::SerializedAST: {
     if (SerializedOK) {
       if (const auto *CachedLocs = getSerializedLocs()) {
         if (!CachedLocs->DocRanges.empty()) {
@@ -158,8 +163,8 @@ RawComment Decl::getRawComment(bool SerializedOK) const {
             if (Range.isValid()) {
               SRCs.push_back({ Range, Context.SourceMgr });
             } else {
-              // if we've run into an invalid range, don't bother trying to load any of
-              // the other comments
+              // if we've run into an invalid range, don't bother trying to load
+              // any of the other comments
               SRCs.clear();
               break;
             }
@@ -178,10 +183,17 @@ RawComment Decl::getRawComment(bool SerializedOK) const {
       Context.setRawComment(this, C->Raw);
       return C->Raw;
     }
-  }
 
-  // Give up.
-  return RawComment();
+    return RawComment();
+  }
+  case FileUnitKind::Source:
+  case FileUnitKind::Builtin:
+  case FileUnitKind::Synthesized:
+  case FileUnitKind::ClangModule:
+  case FileUnitKind::DWARFModule:
+    return RawComment();
+  }
+  llvm_unreachable("invalid file kind");
 }
 
 static const Decl* getGroupDecl(const Decl *D) {