[AST] Only use serialized locs for 'getRawComment()' in symbol graph #36270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For example 'SourceFile' can handle all operations inside 'getSerializedLocs()', but it unnecessarily loads source content in a new buffer, and resolve 'SourceLoc' from the line and the column. And the result is completely useless. rdar://problem/75010520
|
@swift-ci Please smoke test |
|
@bitjammer What's was the intension of the change? 69c4fc4#diff-d87e42f4d1c72f623a9f9246f244b1ad6f375fa7d1dce3d162ebb302d17f8922R869 |
|
@swift-ci Please smoke test Windows |
|
@swift-ci Please smoke test Linux |
benlangmuir
approved these changes
Mar 4, 2021
|
Merging because this is causing serious performance regression. @bitjammer Let me know if you have any concern. |
|
@rintaro I was investigating what I thought was a bug with serialized source locations at the time but it turned out to be nothing. Thank you for fixing the regression. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getRawComment()by defaultgetSerialiedLocs()for decls inSerializedASTFile(Calling it forSourceFiledecls is useless)AllowSerializedparameter infindRequirementDeclWithDocComment()(I just noticed this when investigating the issue)rdar://problem/75010520