Merge pull request #39226 from ahoppen/pr/fix-keypath-completion-crash

[CodeCompletion] Fix a crash in solver-based keypath completion

Author: ahoppen

lib/Sema/TypeCheckCodeCompletion.cpp

@@ -1303,25 +1303,28 @@ void KeyPathTypeCheckCompletionCallback::sawSolution(
       // to look up type variables by their locators.
       auto RootLocator =
           S.getConstraintLocator(KeyPath, {ConstraintLocator::KeyPathRoot});
-      auto BaseVariableType =
+      auto BaseVariableTypeBinding =
           llvm::find_if(S.typeBindings, [&RootLocator](const auto &Entry) {
             return Entry.first->getImpl().getLocator() == RootLocator;
-          })->getSecond();
-      BaseType = S.simplifyType(BaseVariableType);
+          });
+      if (BaseVariableTypeBinding != S.typeBindings.end()) {
+        BaseType = S.simplifyType(BaseVariableTypeBinding->getSecond());
+      }
     }
   } else {
     // We are completing after a component. Get the previous component's result
     // type.
     BaseType = S.simplifyType(S.getType(KeyPath, ComponentIndex - 1));
   }
+  if (BaseType.isNull()) {
+    return;
+  }
 
   // If ExpectedTy is a duplicate of any other result, ignore this solution.
   if (llvm::any_of(Results, [&](const Result &R) {
     return R.BaseType->isEqual(BaseType);
   })) {
     return;
   }
-  if (BaseType) {
-    Results.push_back({BaseType, /*OnRoot=*/(ComponentIndex == 0)});
-  }
+  Results.push_back({BaseType, /*OnRoot=*/(ComponentIndex == 0)});
 }