[CodeCompletion] Fix a crash in solver-based keypath completion #39226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a crash that occurred if no type binding could be found for the key path’s base type. I wasn’t able to find a test case that reproduces this issue. Fixes rdar://81408525
|
@swift-ci Please smoke test |
xedin
reviewed
Sep 9, 2021
| @@ -1303,25 +1303,28 @@ void KeyPathTypeCheckCompletionCallback::sawSolution( | |||
| // to look up type variables by their locators. | |||
| auto RootLocator = | |||
| S.getConstraintLocator(KeyPath, {ConstraintLocator::KeyPathRoot}); | |||
| auto BaseVariableType = | |||
| auto BaseVariableTypeBinding = | |||
There was a problem hiding this comment.
This is very strange, the only reason why root is not in the bindings is key path isn't in scope of the solution since solution always records all of the type variables present in the constraint system...
There was a problem hiding this comment.
My gut feeling was that it’s because the key path was skipped due to invalid code inside result builders. Do you think that might be the cause?
There was a problem hiding this comment.
Hm, maybe if part of the statement is skipped...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a crash that occurred if no type binding could be found for the key path’s base type. I wasn’t able to find a test case that reproduces this issue.
Fixes rdar://81408525