[Serialization] Use decl mangling for local decls, not type mangling. #10022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise we get an error with local generic types. We don't need the complexity of type mangling anyway. https://bugs.swift.org/browse/SR-5038
|
@swift-ci Please smoke test |
|
@bitjammer, @nkcsgexi, @scallanan: what should I do about RemoteAST and TypeReconstruction.cpp? Both of these appear to not handle local types correctly anyway, generic or not; the former explicitly hasn't implemented it and the latter already has a test case that demonstrates it's not working. |
|
Eagerly merging to avoid the crash, but still interested in a response to the above. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise we get an error with local generic types. We don't need the complexity of type mangling anyway.
SR-5038 / rdar://problem/32488971