[Gardening] Cleanup TokenKinds.def #10034
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…age. Added a level of structure to the macro definitions to allow Swift keywords to be cleanly accessed separately from SIL and Swift keywords together. Documented structure and usage.
Used guarantees about undefining macros after import and new SWIFT_KEYWORD abstraction to simplify usage of the Token.def imports.
|
@swift-ci please test |
|
@xwu I can't seem to request you for review, but I've made a lot of the changes that you specified on the original patch |
|
This looks really great to me. Thanks @micahhainline! |
|
@CodaFi Thanks, LGTM! |
|
⛵️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This shepherds #6618.