Skip to content

[ConstraintSolver] Unify value-to-pointer conversion scoring #10092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 7, 2017

Conversation

xedin
Copy link
Contributor

@xedin xedin commented Jun 3, 2017

Instead of having three different scores for - string, array, inout,
let's unify them under a single value-to-pointer score and use
it in appropriate places when simplifying restricted constraints.

Instead of having three different scores for - string, array, inout,
let's unify them under a single value-to-pointer score and use
it in appropriate places when simplifying restricted constraints.
@xedin
Copy link
Contributor Author

xedin commented Jun 3, 2017

@swift-ci please smoke test

@xedin
Copy link
Contributor Author

xedin commented Jun 3, 2017

@swift-ci please test source compatibility

@xedin xedin requested review from DougGregor and rudkx June 3, 2017 07:12
Copy link
Member

@DougGregor DougGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@xedin
Copy link
Contributor Author

xedin commented Jun 7, 2017

@swift-ci please smoke test and merge

@swift-ci swift-ci merged commit af2aca0 into swiftlang:master Jun 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants