(WIP) Fixing up @autoclosure #10094
Closed
(WIP) Fixing up @autoclosure #10094
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The type of an @autoclosure parameter as seen inside a function body should *not* have the @autoclosure attribute. We should only ever see @autoclosure on a parameter type of a function being called, because it introduces an implicit conversion from T => @autoclosure () -> T. Fixes <rdar://problem/20591571> and <rdar://problem/30906031>.
Saying "implicitly non-escaping because it was declared @autoclosure" does not make sense. Parameters of function type are now always non-escaping by default, whether or not they are @autoclosure. This note is a holdover from the Swift 2 days, where escaping was the default, and @autoclosure implied @NoEscape. Now, always emit the basic "implicitly non-escaping" note.
rjmccall
added a commit
to rjmccall/swift
that referenced
this pull request
Jun 19, 2018
This is correct because it's the apparent rule used by CSSimplify: value-to-autoclosure conversion is considered if and only if the input type is not an autoclosure function type. The real solution to this problem is that @autoclosure should be tracked as a bit on the parameter type instead of as a bit on function types. Slava has a PR leading towards that (swiftlang#10094), but it causes a source-compatibility problem when forwarding autoclosures. You really shouldn't be able to forward autoclosures, but that's an issue for the core team to resolve, and in the meantime there's this bug. Fixes rdar://41219750.
|
@xedin fixed this better on master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.